Allow offset in fori loop #4538
Open
+33
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SplotyCode
force-pushed
the
fix/for-loop
branch
from
47db18a to
ef6ec46
Compare
SplotyCode
force-pushed
the
fix/for-loop
branch
from
ef6ec46 to
3b9d6b2
Compare
staabm
reviewed
Nov 8, 2025
staabm
suggested changes
Nov 11, 2025
Contributor
staabm
left a comment
staabm
left a comment
There was a problem hiding this comment.
the newly added tests do not fail without the change you applied to NodeScopeResolver.
you either need to add more/other assertions or adjust the test-code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.